Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate: 2020-06-17 #107

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Integration Candidate: 2020-06-17 #107

merged 4 commits into from
Jun 25, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Jun 23, 2020

Describe the contribution
Fix #98
Fix #104

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/106/checks

Expected behavior changes
PR #100 - Change all individual UI elements to table widgets. Update backend code accordingly

PR #106 - Temporary fix for implicit declaration of endian functions on some systems (RH/CentOs). Note the real fix will be #95, custom implementation of these functions and removal of the messy defines. No build errors on CentOS

System(s) tested on
Ubuntu: Bionic

Additional context
Part of nasa/cFS#106

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleier, NASA-GSFC
Jacob Hageman, NASA-GSFC

lbleier-GSFC and others added 2 commits June 23, 2020 15:54
Backend updated accordingly. Other various tweaks/fixes as needed
Fix #98, Refactor individual UI elements to tables
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2020

This pull request fixes 3 alerts when merging c7f9072 into 52f706b - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request fixes 3 alerts when merging ddee8c8 into 52f706b - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2020

This pull request fixes 3 alerts when merging 63b672a into 52f706b - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@astrogeco astrogeco marked this pull request as ready for review June 25, 2020 02:52
@astrogeco astrogeco merged commit 9cd5304 into master Jun 25, 2020
@skliper skliper added this to the 2.2.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1.11 fails to build on RHEL 7.8 Refactor individual fields to table
3 participants