Fix #399, Deprecate decompress #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
enhancement
CCB:Ready
skliper
force-pushed
the
fix399-decompress-untraced
branch
from
954ba6b to
9b6278c
Compare
|
Forced push comments/doxygen updates to mark API's as deprecated |
skliper
force-pushed
the
fix399-decompress-untraced
branch
from
9b6278c to
fec76a6
Compare
|
Rebased on master |
|
CCB 2020-04-29 : APPROVED |
astrogeco
added
CCB:Approved
|
@skliper can you resolve the conflicts? |
Removes untraced capabilities to decompress libraries or apps on load. For non-startup apps, FS can be used. For startup, recommendation is to compress/decompress as part of boot/startup vs individual applications/libs at load. Also fixes nasa#291, by deprecating decompress it can be moved to the FS app. Also makes nasa#135 N/A, static code analysis issues in decompress
skliper
force-pushed
the
fix399-decompress-untraced
branch
from
fec76a6 to
56e024c
Compare
|
@astrogeco conflicts resolved |
skliper
added a commit
to skliper/cFE
that referenced
this pull request
May 11, 2020
Fix nasa#399, Deprecate decompress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #399
Removes untraced capabilities to decompress libraries or
apps on load. For non-startup apps, FS can be used. For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.
Fix #291
By deprecating decompress it can be moved to the FS app.
Fix #135
Static code analysis issues in decompress now N/A
Testing performed
Steps taken to test the contribution:
Expected behavior changes
No longer automatically decompresses apps/libraries as part of load
System(s) tested on
Additional context
FS app updates will add decompress functionality, and decompress is planned to be implemented as a replaceable library
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC