Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #557, OSAL Guide Scrub #558

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Fix #557, OSAL Guide Scrub #558

merged 6 commits into from
Mar 23, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 15, 2020 •
edited
Loading

Describe the contribution
Fix #557, see issue for list of changes.
These are the changes required in the cFE repo to scrub the OSAL guide

Note 8845570 is the commit related to this issue.

Testing performed
Steps taken to test the contribution:

  1. Nominal build (native) and run, no issues
  2. Make usersguide and confirmed no warnings in build/doc/warnings
  3. cd build/doc/users_guide/latex
  4. make
  5. confirm completes and guide looks ok
  6. Make osalguide and confirmed no warnings in build/doc/warnings
  7. cd build/doc/osalguide/latex
  8. make
  9. confirm completes and guide looks ok

Expected behavior changes
No behavior change other than warnings resolved for doc build

System(s) tested on

  • Hardware: cFS Dev Server 3
  • OS: Ubuntu 18.04
  • Versions: Bundle w/ the commits below

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

skliper added 6 commits March 13, 2020 15:27
@skliper
Fix nasa#540, Scrub User's Guide and related comments
784fe09 
NOTE - Comments/documentation only, no logic updates
Also fixes nasa#403, resolves all warnings
Also fixes nasa#536, comment typo in CFE_SB_RcvMsg implementation header
@skliper
Fix nasa#261, Clarify table never loaded error
0f60675 
Documentation/comment change only.
Moved get address specific information from error code to API.
@skliper
Fix nasa#267, Document SysLog vs Event use
7e248ba 
Documentation/comment only
@skliper
Fix nasa#499, Clarify Get/SetMsgTime effect on cmd msg
71df47f 
Partial fix (see also nasa#545), comments/documentation only
@skliper
Fix nasa#531, Doc MID use for CFE_TBL_NotifyByMessage
0c00f71 
Documentation/comments only
Recommends unique MID for inter-app communications
@skliper
Fix nasa#577, Scrub OSAL user's guide
8845570 
Documentation changes only
@skliper skliper added enhancement CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 15, 2020
@skliper skliper added this to the 6.8.0 milestone Mar 15, 2020
@astrogeco astrogeco added the docs This change only affects documentation. label Mar 18, 2020
@astrogeco
Copy link
Contributor

CCB Approved - 20200318

@astrogeco astrogeco added CCB - 20200318 CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 18, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate March 23, 2020 16:50
@astrogeco astrogeco merged commit fb3ef1c into nasa:integration-candidate Mar 23, 2020
This was referenced Mar 23, 2020
Closed
Merged
@skliper skliper deleted the fix557-osalguide-scrub branch February 1, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation. enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Clean-up related to OSAL user's guide scrub
2 participants
@skliper @astrogeco