Fix #315, ES Performance debug messages #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CCB 20200115 - Needs further review for casting/format cleanup |
skliper
requested changes
Jan 21, 2020
skliper
approved these changes
Feb 3, 2020
astrogeco
added
the
CCB:Ready
ghost
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
For the filter mask values, would it be worth using a fixed length format such as 0x%08X ?
For a 32 bit mask, the leading zeros might make the bit positions more obvious.
Example:
uint32_t test_val1 = 0x111;
printf("test_val 1 = 0x%08X\n",test_val1);
printf("test_val 1 = 0x%x\n",test_val1);
test_val 1 = 0x00000111
test_val 1 = 0x111
|
CCB 20200212 - Approved |
astrogeco
added
CCB:Approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes issue #315, ES Performance debug messages have incorrect parameter
Testing performed
Expected behavior changes
DEBUG messages are now correct.
System(s) tested on:
Oracle VM VirtualBox
OS: ubuntu-19.10
Version: cFE 6.7.3.0; OSAL 5.0.3.0; PSP 1.4.1.0
Contributor Info
Dan Knutsen
GSFC/NASA