Fix #2538, table transaction initial implementation #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Still need to do some documentation updates on this PR. Will follow up with an update. Expecting the documentation-related workflow(s) to fail on this for now. |
jphickey
force-pushed
the
fix-2538-tbl-transaction
branch
4 times, most recently
from
2eddc7b to
17504c4
Compare
There was a problem hiding this comment.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Initial implementation of transaction concept for table API calls. The basic transaction object wraps all of the relevant pointers and state information for the request being processed.
jphickey
force-pushed
the
fix-2538-tbl-transaction
branch
from
17504c4 to
0604676
Compare
|
Documentation updates should be resolved now, pending successful workflow run. |
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 28, 2024
*Combines:* cFE equuleus-rc1+dev120 osal equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2535 - nasa/cFE#2539 *osal* - nasa/osal#1350 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
This was referenced Mar 28, 2024
jphickey
added a commit
that referenced
this pull request
Apr 1, 2024
Correct warnings about uninitialized values
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 1, 2024
*Combines:* cFE equuleus-rc1+dev120 osal equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2535 - nasa/cFE#2539 *osal* - nasa/osal#1350 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 1, 2024
*Combines:* cFE equuleus-rc1+dev120 osal equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2535 - nasa/cFE#2539 *osal* - nasa/osal#1350 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
2 tasks
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Initial implementation of transaction concept for table API calls. The basic transaction object wraps all of the relevant pointers and state information for the request being processed.
Fixes #2538
Testing performed
Build and run all tests
Expected behavior changes
Internal code structure more manageable.
Behavior of external/public API calls should remain the same.
System(s) tested on
Debian
Additional context
Does not really "fix" the problem of race conditions alone, needs more work to actually move/reorg the problem areas. But this doesn't break anything that wasn't already broken (i.e. race conditions in here were there before). They are just more evident (and fixable) now.
Unit and functional tests (mostly) did not need to change for this, aside from a few minor details.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.