Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2378, refactor SB to support additional use cases #2381

Merged
merged 2 commits into from
Jul 2, 2024

Fix #2378, update for code coverage

48dd153
Select commit
Loading
Failed to load commit list.
Merged

Fix #2378, refactor SB to support additional use cases #2381

Fix #2378, update for code coverage
48dd153
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL-coding-standard succeeded Apr 19, 2024 in 7s

73 new alerts

New alerts in code changed by this pull request

  • 29 warnings
  • 44 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 1447 in modules/sb/fsw/src/cfe_sb_api.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice on line 1389 in modules/sb/fsw/src/cfe_sb_api.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check warning on line 502 in modules/evs/fsw/src/cfe_evs_utils.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function EVS_GenerateEventTelemetry is indirectly recursive via this call to
CFE_SB_TransmitMsg
Loading
.
The function EVS_GenerateEventTelemetry is indirectly recursive via this call to
CFE_SB_TransmitMsg
Loading
.

Check warning on line 516 in modules/evs/fsw/src/cfe_evs_utils.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function EVS_GenerateEventTelemetry is indirectly recursive via this call to
CFE_SB_TransmitMsg
Loading
.
The function EVS_GenerateEventTelemetry is indirectly recursive via this call to
CFE_SB_TransmitMsg
Loading
.

Check notice on line 338 in modules/sb/fsw/src/cfe_sb_priv.h

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Hidden pointer indirection Note

The typedef CFE_SB_MessageTxn_PipeHandler_t hides pointer indirection.

Check notice on line 926 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

CFE_SB_TransmitTxn_FindDestinations has too many lines (133, while 60 are allowed).

Check notice on line 573 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

CFE_SB_MessageTxn_GetEventDetails has too many parameters (8, while 6 are allowed).
CFE_SB_MessageTxn_GetEventDetails has too many lines (127, while 60 are allowed).

Check notice on line 1327 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

CFE_SB_ReceiveTxn_ExportReference has too many lines (66, while 60 are allowed).

Check notice on line 3056 in modules/sb/ut-coverage/sb_UT.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

Test_TransmitTxn_FindDestinations has too many lines (126, while 60 are allowed).

Check notice on line 3295 in modules/sb/ut-coverage/sb_UT.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Function too long Note

Test_MessageTxn_GetEventDetails has too many lines (87, while 60 are allowed).

Check warning on line 749 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function CFE_SB_MessageTxn_ReportEvents is indirectly recursive via this call to
CFE_SB_MessageTxn_ReportSingleEvent
Loading
.

Check warning on line 761 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function CFE_SB_MessageTxn_ReportEvents is indirectly recursive via this call to
CFE_SB_MessageTxn_ReportSingleEvent
Loading
.

Check warning on line 718 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function CFE_SB_MessageTxn_ReportSingleEvent is indirectly recursive via this call to
CFE_SB_MessageTxn_GetEventDetails
Loading
.

Check warning on line 723 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function CFE_SB_MessageTxn_ReportSingleEvent is indirectly recursive via this call to
CFE_EVS_SendEventWithAppID
Loading
.
The function CFE_SB_MessageTxn_ReportSingleEvent is indirectly recursive via this call to
CFE_EVS_SendEventWithAppID
Loading
.

Check warning on line 595 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Uses of recursion Warning

The function CFE_SB_MessageTxn_GetEventDetails is indirectly recursive via this call to
CFE_SB_GetPipeName
Loading
.
The function CFE_SB_MessageTxn_GetEventDetails is indirectly recursive via this call to
CFE_SB_GetPipeName
Loading
.

Check warning on line 1529 in modules/sb/fsw/src/cfe_sb_api.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 1552 in modules/sb/fsw/src/cfe_sb_api.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 1343 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 1285 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 976 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 866 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 880 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 826 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check warning on line 721 in modules/sb/fsw/src/cfe_sb_priv.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Side effect in a Boolean expression Warning

This Boolean expression is not side-effect free.

Check notice on line 1344 in modules/sb/fsw/src/cfe_sb_api.c

See this annotation in the file changed.

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.