-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2084, Add support for fractional seconds in epoch #2088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It "looks" fine but I haven't tried working through all the edge cases.
CCB:2022-04-20 APPROVED with Changes
|
@dmknutsen do we need to update CTF scripts for this? |
8fece66
to
f5835d9
Compare
Shouldn't require an update to any scripts - but will effect how we interpret/display time in the plugins...I'll update an push this week. |
Workflow confirmed format fix, thx @jonathan-brandenburg-metecs! |
Fix #2084, Add support for fractional seconds in epoch
*cFE* nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]>
Fix #2084, Add support for fractional seconds in epoch Apply clang-format
*cFE* nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]>
*cFE* nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]>
@jonathan-brandenburg-metecs have you filled out a coporate CLA? |
I'll take care of it |
As I think about it, this submission was done under a NASA task order: SASS-80JSC020D0060-METECS SASS TO 28 - ER6 Gateway CFS Cert FY2 Thus NASA already "owns" my contribution. |
Combines nasa/cFE#2098, v7.0.0-rc4+dev127 nasa/osal#1251, v6.0.0-rc4+dev74 nasa/PSP#343, v1.6.0-rc4+dev34 **cFE** nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch nasa/cFE#2044, Remove redundant word in App Developers Guide nasa/cFE#2099, UT updates for alternate time configuration **RTEMS 6 Support nasa/cFE#2097, update rtems toolchain files nasa/osal#1250, add os-impl-no-select.c for RTEMS nasa/PSP#339, Update RTEMS CMake Platform File **PSP** nasa/PSP#341, Add cpu affinity example **Fix Broken CodeQL Workflow Reference** nasa/PSP#337 nasa/osal#1249 nasa/sample_lib#82 nasa/sample_app#173 nasa/sch_lab#113 nasa/ci_lab#109 nasa/to_lab#120 nasa/elf2cfetbl#110 nasa/tblCRCTool#68 nasa/cFS-GroundSystem#214 Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]> Co-authored-by: Alan Cudmore <[email protected]> Co-authored-by: Hugo Valente <[email protected]>
Combines nasa/cFE#2098, v7.0.0-rc4+dev127 nasa/osal#1251, v6.0.0-rc4+dev74 nasa/PSP#343, v1.6.0-rc4+dev34 **cFE** nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch nasa/cFE#2044, Remove redundant word in App Developers Guide nasa/cFE#2099, UT updates for alternate time configuration **RTEMS 6 Support nasa/cFE#2097, update rtems toolchain files nasa/osal#1250, add os-impl-no-select.c for RTEMS nasa/PSP#339, Update RTEMS CMake Platform File **PSP** nasa/PSP#341, Add cpu affinity example **Fix Broken CodeQL Workflow Reference** nasa/PSP#337 nasa/osal#1249 nasa/sample_lib#82 nasa/sample_app#173 nasa/sch_lab#113 nasa/ci_lab#109 nasa/to_lab#120 nasa/elf2cfetbl#110 nasa/tblCRCTool#68 nasa/cFS-GroundSystem#214 Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]> Co-authored-by: Alan Cudmore <[email protected]> Co-authored-by: Hugo Valente <[email protected]>
Combines nasa/cFE#2098, v7.0.0-rc4+dev127 nasa/osal#1251, v6.0.0-rc4+dev74 nasa/PSP#343, v1.6.0-rc4+dev34 **cFE** nasa/cFE#2078, Adds truncation warning suppression flags nasa/cFE#2094, Doc deploy from local workflow on main-branch push nasa/cFE#2088, Add support for fractional seconds in epoch nasa/cFE#2044, Remove redundant word in App Developers Guide nasa/cFE#2099, UT updates for alternate time configuration **RTEMS 6 Support nasa/cFE#2097, update rtems toolchain files nasa/osal#1250, add os-impl-no-select.c for RTEMS nasa/PSP#339, Update RTEMS CMake Platform File **PSP** nasa/PSP#341, Add cpu affinity example **Fix Broken CodeQL Workflow Reference** nasa/PSP#337 nasa/osal#1249 nasa/sample_lib#82 nasa/sample_app#173 nasa/sch_lab#113 nasa/ci_lab#109 nasa/to_lab#120 nasa/elf2cfetbl#110 nasa/tblCRCTool#68 nasa/cFS-GroundSystem#214 Co-authored-by: Justin Figueroa <[email protected]> Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Jonathan Branderburg <[email protected]> Co-authored-by: Alan Cudmore <[email protected]> Co-authored-by: Hugo Valente <[email protected]>
Describe the contribution
Fix #2084
Testing performed
Build/run unit tests, confirm same coverage of time module
Expected behavior changes
Epoch contains a value for fractional seconds in the form of a CFE_MISSION_TIME_EPOCH_MICROS. This value is included in the time value before generating the printable string in CFE_TIME_Print
System(s) tested on
Hardware: i7/Virtual Box
OS: CentOS Linux 7.9
Versions: Bundle main plus this component
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jonathan Brandenburg - NASA/JSC