Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2084, Add support for fractional seconds in epoch #2088

Merged
merged 1 commit into from
May 19, 2022

Conversation

jonathan-brandenburg-metecs

Describe the contribution
Fix #2084

Testing performed
Build/run unit tests, confirm same coverage of time module

Expected behavior changes
Epoch contains a value for fractional seconds in the form of a CFE_MISSION_TIME_EPOCH_MICROS. This value is included in the time value before generating the printable string in CFE_TIME_Print

System(s) tested on

Hardware: i7/Virtual Box
OS: CentOS Linux 7.9
Versions: Bundle main plus this component
Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jonathan Brandenburg - NASA/JSC

@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 19, 2022
@astrogeco astrogeco requested review from jphickey and skliper April 19, 2022 00:03
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It "looks" fine but I haven't tried working through all the edge cases.

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 20, 2022
@astrogeco
Copy link
Contributor

CCB:2022-04-20 APPROVED with Changes

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Apr 20, 2022
@astrogeco
Copy link
Contributor

@dmknutsen do we need to update CTF scripts for this?

@dmknutsen
Copy link
Contributor

Shouldn't require an update to any scripts - but will effect how we interpret/display time in the plugins...I'll update an push this week.

@skliper
Copy link
Contributor

skliper commented Apr 20, 2022

Workflow confirmed format fix, thx @jonathan-brandenburg-metecs!

astrogeco added a commit that referenced this pull request May 2, 2022
Fix #2084, Add support for fractional seconds in epoch
astrogeco added a commit to nasa/cFS that referenced this pull request May 2, 2022
*cFE*

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

Co-authored-by: Justin Figueroa <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Jonathan Branderburg <[email protected]>
astrogeco added a commit that referenced this pull request May 2, 2022
Fix #2084, Add support for fractional seconds in epoch

Apply clang-format
astrogeco added a commit to nasa/cFS that referenced this pull request May 2, 2022
*cFE*

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

Co-authored-by: Justin Figueroa <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Jonathan Branderburg <[email protected]>
astrogeco added a commit to astrogeco/cFS that referenced this pull request May 4, 2022
*cFE*

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

Co-authored-by: Justin Figueroa <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Jonathan Branderburg <[email protected]>
@astrogeco
Copy link
Contributor

@astrogeco astrogeco added the CCB:PendingCLA External contribution pending CLA confirmation label May 4, 2022
@jonathanbrandenburg
Copy link

@jonathan-brandenburg-metecs have you filled out a coporate CLA? Check out https://github.com/nasa/cFS/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

I'll take care of it

@jonathanbrandenburg
Copy link

@jonathan-brandenburg-metecs have you filled out a coporate CLA? Check out https://github.com/nasa/cFS/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

As I think about it, this submission was done under a NASA task order: SASS-80JSC020D0060-METECS SASS TO 28 - ER6 Gateway CFS Cert FY2

Thus NASA already "owns" my contribution.

@astrogeco astrogeco removed the CCB:PendingCLA External contribution pending CLA confirmation label May 18, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request May 18, 2022
Combines

nasa/cFE#2098, v7.0.0-rc4+dev127
nasa/osal#1251, v6.0.0-rc4+dev74
nasa/PSP#343, v1.6.0-rc4+dev34

**cFE**

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

nasa/cFE#2044, Remove redundant word in App Developers Guide

nasa/cFE#2099,  UT updates for alternate time configuration

**RTEMS 6 Support

nasa/cFE#2097, update rtems toolchain files

nasa/osal#1250, add os-impl-no-select.c for RTEMS

nasa/PSP#339, Update RTEMS CMake Platform File

**PSP**

nasa/PSP#341, Add cpu affinity example

**Fix Broken CodeQL Workflow Reference**

nasa/PSP#337

nasa/osal#1249

nasa/sample_lib#82

nasa/sample_app#173

nasa/sch_lab#113

nasa/ci_lab#109

nasa/to_lab#120

nasa/elf2cfetbl#110

nasa/tblCRCTool#68

nasa/cFS-GroundSystem#214

Co-authored-by: Justin Figueroa <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Jonathan Branderburg <[email protected]>
Co-authored-by: Alan Cudmore <[email protected]>
Co-authored-by: Hugo Valente <[email protected]>
astrogeco added a commit to nasa/cFS that referenced this pull request May 18, 2022
Combines

nasa/cFE#2098, v7.0.0-rc4+dev127
nasa/osal#1251, v6.0.0-rc4+dev74
nasa/PSP#343, v1.6.0-rc4+dev34

**cFE**

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

nasa/cFE#2044, Remove redundant word in App Developers Guide

nasa/cFE#2099,  UT updates for alternate time configuration

**RTEMS 6 Support

nasa/cFE#2097, update rtems toolchain files

nasa/osal#1250, add os-impl-no-select.c for RTEMS

nasa/PSP#339, Update RTEMS CMake Platform File

**PSP**

nasa/PSP#341, Add cpu affinity example

**Fix Broken CodeQL Workflow Reference**

nasa/PSP#337

nasa/osal#1249

nasa/sample_lib#82

nasa/sample_app#173

nasa/sch_lab#113

nasa/ci_lab#109

nasa/to_lab#120

nasa/elf2cfetbl#110

nasa/tblCRCTool#68

nasa/cFS-GroundSystem#214

Co-authored-by: Justin Figueroa <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Jonathan Branderburg <[email protected]>
Co-authored-by: Alan Cudmore <[email protected]>
Co-authored-by: Hugo Valente <[email protected]>
@astrogeco astrogeco merged commit 15d4e05 into nasa:main May 19, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request May 19, 2022
Combines

nasa/cFE#2098, v7.0.0-rc4+dev127
nasa/osal#1251, v6.0.0-rc4+dev74
nasa/PSP#343, v1.6.0-rc4+dev34

**cFE**

nasa/cFE#2078, Adds truncation warning suppression flags

nasa/cFE#2094, Doc deploy from local workflow on main-branch push

nasa/cFE#2088, Add support for fractional seconds in epoch

nasa/cFE#2044, Remove redundant word in App Developers Guide

nasa/cFE#2099,  UT updates for alternate time configuration

**RTEMS 6 Support

nasa/cFE#2097, update rtems toolchain files

nasa/osal#1250, add os-impl-no-select.c for RTEMS

nasa/PSP#339, Update RTEMS CMake Platform File

**PSP**

nasa/PSP#341, Add cpu affinity example

**Fix Broken CodeQL Workflow Reference**

nasa/PSP#337

nasa/osal#1249

nasa/sample_lib#82

nasa/sample_app#173

nasa/sch_lab#113

nasa/ci_lab#109

nasa/to_lab#120

nasa/elf2cfetbl#110

nasa/tblCRCTool#68

nasa/cFS-GroundSystem#214

Co-authored-by: Justin Figueroa <[email protected]>
Co-authored-by: Jacob Hageman <[email protected]>
Co-authored-by: Jonathan Branderburg <[email protected]>
Co-authored-by: Alan Cudmore <[email protected]>
Co-authored-by: Hugo Valente <[email protected]>
@skliper skliper added this to the Draco milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for fractional seconds in epoch definition
5 participants