Fix #1141, pipe name unset #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-1141-fixup-debug-event
branch
from
4404743 to
92c2337
Compare
jphickey
added
CCB:FastTrack
CCB:Ready
|
Suggesting fast track here, as this fixes an issue in "main" when one enables debug events. |
Do not print the pipe name in the debug event, just pipe ID.
jphickey
force-pushed
the
fix-1141-fixup-debug-event
branch
from
92c2337 to
a97a268
Compare
|
Correction - the original idea of just getting the pipe name broke many unit tests because there is (strangely) a debug event for getting a pipe name, and all unit test event counts became wrong again. Simpler and better fix to just not print the name, only ID. We should also remove the debug event on CFE_SB_GetPipeName success. This generates a large number of clutter events, and makes UT fragile, and none of the other "get name" APIs have an event on success. |
skliper
approved these changes
Jan 29, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 3, 2021
astrogeco
added
CCB:2021-02-02
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1141 Only print the Pipe ID in the debug event
Testing performed
Enable debug events and run CFE, observe events
Expected behavior changes
Debug subscription events have pipe ID, no name.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.