Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #996, Remove CFE_PLATFORM_SB_MAX_PIPE_DEPTH in favor of OS_QUEUE_MAX_DEPTH #1111

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 21, 2021

Describe the contribution
Fix #996, Remove CFE_PLATFORM_SB_MAX_PIPE_DEPTH in favor of OS_QUEUE_MAX_DEPTH

Testing performed
Built and ran unit tests, passed

Expected behavior changes
Depth parameter in command now checked prior to attempting OSAL call

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 21, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 21, 2021
@skliper skliper force-pushed the fix996-max_queue_depth branch from 8e3a5ff to bd051ff Compare January 27, 2021 15:13
@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate February 3, 2021 22:32
@astrogeco astrogeco merged commit 64aeec0 into nasa:integration-candidate Feb 3, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 3, 2021
@skliper skliper deleted the fix996-max_queue_depth branch April 1, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_PLATFORM_SB_MAX_PIPE_DEPTH reporting and use misleading in relation to OS_MAX_QUEUE_DEPTH
2 participants