Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate implicit entries in MISSION_DEPS to defaults file #746

Closed
jphickey opened this issue Jun 17, 2020 · 0 comments · Fixed by #751 or #765
Closed

Consolidate implicit entries in MISSION_DEPS to defaults file #746

jphickey opened this issue Jun 17, 2020 · 0 comments · Fixed by #751 or #765
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The build currently sets MISSION_DEPS as a list of dependencies which is basically the CFE core and OSAL by default. There is a desire to consolidate all "fixed" entries into a separate defaults file for increased visibility and manageability.

Describe the solution you'd like
These two dependencies can be consolidated into the MISSION_CORE_MODULES default list being proposed in PR #740, but this also depends on #728 so it needs to be implemented separately.

Additional context
This is a dependency of both PR #728 and #740. Original discussion here:
#740 (comment)

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jun 19, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Jun 19, 2020
Put more dependencies into the "mission_defaults.cmake" file for
more visibility and ease of configuration.  This now includes all
"implicit" modules such as cfe-core, osal, and psp.

Also push the calls to "generate_config_includefile" to a sub-script
which can be distributed with each app and evaluated as part of the
build.  This reduces dependencies on special naming conventions like
"fsw/mission_inc" and "fsw/platform_inc", and apps can explicitly manage
the files that users are expected to override.
jphickey added a commit to jphickey/cFE that referenced this issue Jun 26, 2020
Put more dependencies into the "mission_defaults.cmake" file for
more visibility and ease of configuration.  This now includes all
"implicit" modules such as cfe-core, osal, and psp.

Also push the calls to "generate_config_includefile" to a sub-script
which can be distributed with each app and evaluated as part of the
build.  This reduces dependencies on special naming conventions like
"fsw/mission_inc" and "fsw/platform_inc", and apps can explicitly manage
the files that users are expected to override.
astrogeco added a commit that referenced this issue Jul 1, 2020
astrogeco pushed a commit that referenced this issue Jul 1, 2020
Put more dependencies into the "mission_defaults.cmake" file for
more visibility and ease of configuration.  This now includes all
"implicit" modules such as cfe-core, osal, and psp.

Also push the calls to "generate_config_includefile" to a sub-script
which can be distributed with each app and evaluated as part of the
build.  This reduces dependencies on special naming conventions like
"fsw/mission_inc" and "fsw/platform_inc", and apps can explicitly manage
the files that users are expected to override.
astrogeco pushed a commit that referenced this issue Jul 26, 2020
Put more dependencies into the "mission_defaults.cmake" file for
more visibility and ease of configuration.  This now includes all
"implicit" modules such as cfe-core, osal, and psp.

Also push the calls to "generate_config_includefile" to a sub-script
which can be distributed with each app and evaluated as part of the
build.  This reduces dependencies on special naming conventions like
"fsw/mission_inc" and "fsw/platform_inc", and apps can explicitly manage
the files that users are expected to override.
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants