We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug CFE_SB_ValidateChecksum claims it returns true if not supported:
cFE/fsw/cfe-core/src/inc/cfe_sb.h
Lines 1314 to 1316 in d217ca3
but also claims it returns false:
Lines 1321 to 1323 in d217ca3
and then implements a false return:
cFE/fsw/cfe-core/src/sb/cfe_sb_util.c
Lines 398 to 401 in d217ca3
To Reproduce Read the code.
Expected behavior Consistency
Code snips See above
System observed on: N/A
Additional context None
Reporter Info Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
I'd expect this sort of inconsistency to be uncovered during unit test development.
Sorry, something went wrong.
Fix nasa#711, Update SB/CCSDS FSW for msg module
8563679
- Fix nasa#733: Validate checksum description update - Fix nasa#597: Remove local endian SID macros - Updates SB to use msg module - General cleanup
skliper
Successfully merging a pull request may close this issue.
Describe the bug
CFE_SB_ValidateChecksum claims it returns true if not supported:
cFE/fsw/cfe-core/src/inc/cfe_sb.h
Lines 1314 to 1316 in d217ca3
but also claims it returns false:
cFE/fsw/cfe-core/src/inc/cfe_sb.h
Lines 1321 to 1323 in d217ca3
and then implements a false return:
cFE/fsw/cfe-core/src/sb/cfe_sb_util.c
Lines 398 to 401 in d217ca3
To Reproduce
Read the code.
Expected behavior
Consistency
Code snips
See above
System observed on:
N/A
Additional context
None
Reporter Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: