Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSG API hook to validate a message prior to returning buffer from SB #2337

Closed
jphickey opened this issue May 17, 2023 · 0 comments · Fixed by #2338
Closed

Add MSG API hook to validate a message prior to returning buffer from SB #2337

jphickey opened this issue May 17, 2023 · 0 comments · Fixed by #2338

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If a user wants to add additional error checking within the header fields, such as a CRC, there is currently no easy way to validate the value as part of the receive buffer process.

Describe the solution you'd like
Add a hook to validate the message before returning from SB.

Additional context
This can be a no-op in the default build, as only the CMDs have a (weak) checksum, and that was never really enforced/checked in CFS anyway. So for backward compatibility the implementation should be permissive. But if the user has customized MSG with additional fields and logic, they could implement more validation using this hook.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this May 17, 2023
dzbaker added a commit that referenced this issue May 22, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants