Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test won't build with external time source configuration #2090

Closed
skliper opened this issue Apr 18, 2022 · 1 comment · Fixed by #2099 or #2098
Closed

Unit test won't build with external time source configuration #2090

skliper opened this issue Apr 18, 2022 · 1 comment · Fixed by #2099 or #2098
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Apr 18, 2022

Is your feature request related to a problem? Please describe.
Many failures in build with ENABLE_UNIT_TESTS=true and the following settings:

#define CFE_PLATFORM_TIME_CFG_SOURCE true
#define CFE_PLATFORM_TIME_CFG_SRC_TIME true
#define CFE_MISSION_TIME_CFG_FAKE_TONE false

This has already been noted in the general time unit testing issue #109 which includes many other unit test issues with changing time config. Raising priority on this one with a unique issue since it's currently a stakeholder impact.

Describe the solution you'd like
Fix this configuration at minimum, which is often used when supplying cFS with time from an external source (or app).

Describe alternatives you've considered
Time services does need a general refactor as noted in #302, many issues w/ the unit tests as noted in #109.
Really would benefit from converting the configuration files to cmake as described in #2089.

Additional context
#2072 fixed the build issue, but unit test fails to build.

Requester Info
Jacob Hageman - NASA/GSFC per stakeholder request

@skliper skliper added this to the Draco milestone Apr 18, 2022
@skliper
Copy link
Contributor Author

skliper commented Apr 18, 2022

Ping @jonathan-brandenburg-metecs for awareness.

@skliper skliper self-assigned this May 11, 2022
skliper added a commit to skliper/cFE that referenced this issue May 11, 2022
astrogeco added a commit that referenced this issue May 18, 2022
Fix #2090, UT updates for alternate time configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant