Comments/document cleanup relative to TBL/TIME review

[skliper]

Is your feature request related to a problem? Please describe.
CFE_TBL_Update, CFE_TBL_Validate, and CFE_TBL_DumpToBuffer are all performed by CFE_TBL_Manage if there's a pending request. Clarify in API documentation for all 4 (missing completely from CFE_TBL_DumpToBuffer).

s/Addresses/Address, this should cross reference, not self reference:

cFE/modules/core_api/fsw/inc/cfe_tbl.h

Line 472 in 82c1bd4

** call this function or #CFE_TBL_GetAddresses.

Add short description of spacecraft time, it's number of seconds since the epoch as set in mission configuration

cFE/modules/core_api/fsw/inc/cfe_time.h

Line 70 in 82c1bd4

** This routine returns the current spacecraft time. The time returned

Self reference doesn't make sense:

cFE/modules/core_api/fsw/inc/cfe_time.h

Lines 73 to 75 in 82c1bd4

	** or #CFE_MISSION_TIME_CFG_DEFAULT_UTC as true at compile time. To maintain re-usability
	** across missions, most applications should be using this function
	** (or #CFE_TIME_GetTime) rather than the specific routines for getting UTC/TAI directly.

There is no API to set or adjust leap seconds or SCTF, this should be done by ground command only:

cFE/modules/core_api/fsw/inc/cfe_time.h

Lines 218 to 219 in 82c1bd4

	** Applications cannot set or adjust the STCF; that can only be done
	** through ground commands. However, science applications may want to

cFE/modules/core_api/fsw/inc/cfe_time.h

Lines 240 to 241 in 82c1bd4

	** and universal coordinated time (UTC). Applications cannot set or
	** adjust the leap seconds; that can only be done through ground commands.

Now called by a timer, not PSP:

cFE/modules/core_api/fsw/inc/cfe_time.h

Line 708 in 82c1bd4

** \brief This function should be called from the system PSP layer once per second

HK command handler also sends the table registry packet (if requested) and dumps "dump-only tables" that are pending, document:

cFE/modules/tbl/fsw/src/cfe_tbl_task_cmds.h

Lines 126 to 127 in 84ba9a9

	** \par Description
	** Constructs a Housekeeping Packet (#CFE_TBL_HousekeepingTlm_t) from task data and sends it out

s/issued/issues:

cFE/modules/tbl/fsw/src/cfe_tbl_task_cmds.c

Line 1266 in 84ba9a9

* This is because TBL services issued a different event ID in some cases if

Remove commented out verification check using sizeof from cfe_tbl_verify.h:

cFE/modules/tbl/fsw/src/cfe_tbl_verify.h

Lines 76 to 81 in 84ba9a9

	/* the following check is removed because some compilers cannot handle the sizeof operator in a #if statement */
	/*
	#if sizeof(CFE_PLATFORM_TBL_DEFAULT_REG_DUMP_FILE) > OS_MAX_PATH_LEN
	#error The length (including NULL terminator) of CFE_PLATFORM_TBL_DEFAULT_REG_DUMP_FILE cannot be greater than
	OS_MAX_PATH_LEN #endif
	*/

Remove pointless comment:

cFE/modules/time/fsw/src/cfe_time_tone.c

Lines 714 to 716 in 84ba9a9

	/*
	** It is possible to call this func with static time value...
	*/

Describe the solution you'd like
Fix

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC