Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace loop with single memset in CFE_SB_SendStatsCmd #1472

Open
skliper opened this issue Apr 30, 2021 · 0 comments · May be fixed by #2182
Open

Replace loop with single memset in CFE_SB_SendStatsCmd #1472

skliper opened this issue Apr 30, 2021 · 0 comments · May be fixed by #2182
Labels
CFS-42 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 30, 2021

Is your feature request related to a problem? Please describe.
Loop not needed

cFE/modules/sb/fsw/src/cfe_sb_task.c

Lines 796 to 802 in c8b5e00

while (PipeStatCount > 0)
{
memset(PipeStatPtr, 0, sizeof(*PipeStatPtr));
++PipeStatPtr;
--PipeStatCount;
}

Describe the solution you'd like
Just memset the sizeof*count.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Oct 25, 2022
@thnkslprpt
Fix nasa#1472, Replace while loop with single memset
64db8ec
@thnkslprpt thnkslprpt linked a pull request Oct 25, 2022 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Mar 14, 2023
@thnkslprpt
Fix nasa#1472, Replace while loop with single memset
c4ce598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-42 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1472, Replace while loop with single memset thnkslprpt/cFE
1 participant
@skliper