You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewing how CFE_ES_SYSLOG_APPEND is currently used, I'm having a hard time justifying why it even needs to exist at all anymore. I think previously it was used in more places, perhaps, but now its down to just 4 instances in CDS code, and I can't see any reason why those 4 places can't just use CFE_ES_WriteToSysLog like everything else does.
It's an internal macro in cfe_es_log.h - not public - so my recommendation is to just remove it entirely.
Is your feature request related to a problem? Please describe.
Use of multiline macros should be avoided (per coding standard):
cFE/modules/es/fsw/src/cfe_es_log.h
Lines 100 to 106 in e80aae9
Describe the solution you'd like
Replaced with inline, or one line macro/inline combo
Describe alternatives you've considered
Wrap with do {...} while(0), see https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: