Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the cmake/sample_defs/default_osconfig.cmake to be just overrides/changes from osal/default_config.cmake #1343

Closed
skliper opened this issue Apr 14, 2021 · 0 comments · Fixed by #1451 or #1492
Closed

Update the cmake/sample_defs/default_osconfig.cmake to be just overrides/changes from osal/default_config.cmake #1343

skliper opened this issue Apr 14, 2021 · 0 comments · Fixed by #1451 or #1492
Assignees
@jphickey
Labels
build-system enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 14, 2021

Is your feature request related to a problem? Please describe.
default_osconfig.cmake repeats many of the settings with the same selection as in default_config.cmake, confusing dependency

Describe the solution you'd like
Remove duplication, document in default_osconfig.cmake that it's for overriding values in default_config.cmake.

Describe alternatives you've considered
None

Additional context
Came up when trying to figure out why OSAL coverage test results were different at the bundle level vs osal level, wasn't clear that default_config.cmake was being used and hard to sort out what's actually being changed in default_osconfig.cmake

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 14, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Apr 29, 2021
@jphickey
Fix nasa#1343, OSAL config file simplification
bbc4ff6 
The CFE framework build uses mostly default values for OSAL compile
time configuration.  There are just a few exceptions where the
CFE build is tuned for a more debug-friendly result.

This updates the configuration files in "sample_defs" to reflect
only those values which are set to a non-default value, along with
information about why the configurable item is changed. Currently,
these are only items related to debugging.

This change also includes more documentation/comments about how this
configuration facility works and where to find information on the
complete set of options available (which is OSAL version dependent).
@jphickey jphickey mentioned this issue Apr 29, 2021
Merged
jphickey added a commit to jphickey/cFE that referenced this issue May 5, 2021
@jphickey
Update nasa#1343, Move priority to "native" config file
63d11eb 
By setting OSAL_CONFIG_UTILITYTASK_PRIORITY in the "native_osconfig"
file instead of the default file, it will only apply when building
with SIMULATION=native.  Deployment builds will use the low priority
default value.
astrogeco added a commit that referenced this issue May 11, 2021
@astrogeco
Merge pull request #1451 from jphickey/fix-1343-osal-config
66a630f 
Fix #1343, OSAL config file simplification
@astrogeco astrogeco mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
build-system enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper