Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant check in CFE_EVS_EarlyInit #1261

Closed
skliper opened this issue Mar 24, 2021 · 0 comments · Fixed by #1263 or #1258
Closed

Redundant check in CFE_EVS_EarlyInit #1261

skliper opened this issue Mar 24, 2021 · 0 comments · Fixed by #1263 or #1258
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 24, 2021

Is your feature request related to a problem? Please describe.
Redundant check:

if (Status == CFE_SUCCESS)

Only way to get here is if it's already CFE_SUCCESS

Describe the solution you'd like
Remove redundant check, false condition can never execute (would require returning from the CFE_PSP_Panic)

Describe alternatives you've considered
None

Additional context
Static analysis warning

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Mar 24, 2021
@skliper skliper self-assigned this Mar 24, 2021
skliper added a commit to skliper/cFE that referenced this issue Mar 24, 2021
skliper added a commit to skliper/cFE that referenced this issue Mar 24, 2021
skliper added a commit to skliper/cFE that referenced this issue Mar 24, 2021
astrogeco added a commit that referenced this issue Mar 29, 2021
Fix #1261, Remove redundant checks in CFE_EVS_EarlyInit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant