CFE_SB_ReceiveBuffer() should use CFE_SB_TimeOut_t for the TimeOut parameter

[CDKnightNASA]

In cfe_sb.h...

cFE/fsw/cfe-core/src/inc/cfe_sb.h

Line 161 in 56397a3

typedef uint32 CFE_SB_TimeOut_t;

But below, the CFE_SB_ReceiveBuffer() takes uint32 for the timeout...

cFE/fsw/cfe-core/src/inc/cfe_sb.h

Line 647 in 56397a3

CFE_Status_t CFE_SB_ReceiveBuffer(CFE_SB_Buffer_t **BufPtr, CFE_SB_PipeId_t PipeId, int32 TimeOut);

Shouldn't it be using the CFE_SB_TimeOut_t type instead of uint32 for the TimeOut parameter?

[CDKnightNASA]

...or, as the docs say, "...Internally used by SB in the #CFE_SB_ReceiveBuffer API...", then should it be exposed in cfe_sb.h at all? Given that it's also a uint32, this is confusing to me.

[skliper]

I didn't change the arguments from:

cFE/fsw/cfe-core/src/sb/cfe_sb_api.c

Lines 1503 to 1505 in 27cc7df

	int32 CFE_SB_RcvMsg(CFE_SB_MsgPtr_t *BufPtr,
	CFE_SB_PipeId_t PipeId,
	int32 TimeOut)

I'm not aware of the history of CFE_SB_TimeOut_t, it's only used in the CFE_SB_ReadQueue API. An abstraction here seems like overkill to me (osal uses int32 for timeouts all over).

EDIT - "didn't change..." other than the buffer change