Merge pull request #2400 from skliper:fix1991-triggermode_check

Fix #1991, TriggerMode unsigned compare with 0
nasa · Sep 1, 2023 · 11fa058 · 11fa058
2 parents 92887fa + 126e23d
commit 11fa058
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/modules/es/fsw/src/cfe_es_perf.c b/modules/es/fsw/src/cfe_es_perf.c
@@ -155,8 +155,7 @@ int32 CFE_ES_StartPerfDataCmd(const CFE_ES_StartPerfDataCmd_t *data)
         PerfDumpState->PendingState == CFE_ES_PerfDumpState_IDLE)
     {
         /* Make sure Trigger Mode is valid */
-        /* cppcheck-suppress unsignedPositive */
-        if ((CmdPtr->TriggerMode >= CFE_ES_PERF_TRIGGER_START) && (CmdPtr->TriggerMode < CFE_ES_PERF_MAX_MODES))
+        if (CmdPtr->TriggerMode < CFE_ES_PERF_MAX_MODES)
         {
             CFE_ES_Global.TaskData.CommandCounter++;