Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76, Squash static analysis (CodeQL) uninitialized variable warning #77

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/dox_src/cfs_sc.dox
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@
time tag in the overlap region (including the switch command) this logic
does not get used. In either case, the switch can be performed without
sending any duplicate commands to be sent out. There are certain conditions
that can cause a ATS switch that is pending to be canceled. If the ATP is
that can cause an ATS switch that is pending to be canceled. If the ATP is
stopped by the ground while the ATP is waiting for a "safe" time to switch,
then the switch will not occur. Also if the ATP detects the end of the ATS
buffer before there is a "safe" time to switch, the switch will be canceled.
Expand Down
2 changes: 1 addition & 1 deletion fsw/inc/sc_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@
* \par Type: ERROR
*
* \par Cause:
* This event message is issued when a ATS command that was about to be sent out
* This event message is issued when an ATS command that was about to be sent out
* failed checksum validation, and the Continue-ATS-on_checksum-Failure flag was
* set to 'FALSE'
*/
Expand Down
10 changes: 5 additions & 5 deletions fsw/src/sc_atsrq.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,11 @@ void SC_StopAtsCmd(const CFE_SB_Buffer_t *BufPtr)
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
bool SC_BeginAts(uint16 AtsIndex, uint16 TimeOffset)
{
SC_AtsEntryHeader_t *Entry; /* ATS table entry pointer */
int32 EntryIndex; /* ATS entry location in table */
SC_AbsTimeTag_t ListCmdTime; /* list entry execution time */
int32 TimeIndex; /* the current time buffer index */
int32 CmdIndex; /* ATS command index (cmd num - 1) */
SC_AtsEntryHeader_t *Entry; /* ATS table entry pointer */
int32 EntryIndex; /* ATS entry location in table */
SC_AbsTimeTag_t ListCmdTime = 0; /* list entry execution time */
int32 TimeIndex; /* the current time buffer index */
int32 CmdIndex; /* ATS command index (cmd num - 1) */
bool ReturnCode;
SC_AbsTimeTag_t TimeToStartAts; /* the REAL time to start the ATS */
uint16 CmdsSkipped = 0;
Expand Down