Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squash static analysis (CodeQL) uninitialized variable warning #76

Closed
2 tasks done
thnkslprpt opened this issue Mar 13, 2023 · 0 comments · Fixed by #77
Closed
2 tasks done

Squash static analysis (CodeQL) uninitialized variable warning #76

thnkslprpt opened this issue Mar 13, 2023 · 0 comments · Fixed by #77
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Code snips
https://github.com/nasa/SC/pull/55/checks?check_run_id=11949908681
image

Describe the bug
ListCmdTime variable triggering CodeQL (potentially) uninitialized variable warning on some PRs.
CodeQL is apparently unable to confirm if ListCmdTime is assigned a value in all execution paths (i.e. if the top while block will always execute at least once).

Expected behavior
Code should compile without any serious static analysis failures.

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Mar 13, 2023
@thnkslprpt
Fix nasa#76, Squash static analysis (CodeQL) uninitialized variable w…
dd4feb8 
…arning
@thnkslprpt thnkslprpt mentioned this issue Mar 13, 2023
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Mar 14, 2023
@thnkslprpt
Fix nasa#76, Squash static analysis (CodeQL) uninitialized variable w…
6ceaa98 
…arning
dzbaker added a commit that referenced this issue Jun 1, 2023
@dzbaker
Merge pull request #77 from thnkslprpt/fix-76-uninitialized-variable-…
d2565d6 
…warning

Fix #76, Squash static analysis (CodeQL) uninitialized variable warning
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #76, Squash static analysis (CodeQL) uninitialized variable warning thnkslprpt/SC
3 participants
@thnkslprpt @dmknutsen @chillfig