Fix #440 - rename parameter in CFE_PSP_MemSet handler to align with stub and actual code #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichLandau
approved these changes
Nov 20, 2024
|
Seems PSP_MemCopy handler/stub has the same problem, I'll fix and rebase. |
…andlers to align with stub and actual code
CDKnightNASA
force-pushed
the
fix440-memset_handler_param
branch
from
45d98d7 to
799d25a
Compare
|
also fixed CFE_PSP_MemCpy |
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Tvisha Andharia <[email protected]> Co-authored by: Chris Knight <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Tvisha Andharia <[email protected]> Co-authored by: Chris Knight <[email protected]>
dzbaker
reviewed
Dec 10, 2024
| @@ -45,7 +45,7 @@ void UT_DefaultHandler_CFE_PSP_MemCpy(void *UserObj, UT_EntryKey_t FuncKey, cons | |||
| /* CFE_PSP_MemCpy(void *dest, const void *src, uint32 size) */ | |||
| void * dest = UT_Hook_GetArgValueByName(Context, "dest", void *); | |||
| const void *src = UT_Hook_GetArgValueByName(Context, "src", const void *); | |||
| uint32 size = UT_Hook_GetArgValueByName(Context, "size", uint32); | |||
| uint32 n = UT_Hook_GetArgValueByName(Context, "n", uint32); | |||
There was a problem hiding this comment.
Renamed variable was not updated in memcpy() on line 54. I've corrected this in commit e0fd658.
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 10, 2024
*Combines:* cFE equuleus-rc1+dev219 osal equuleus-rc1+dev93 PSP equuleus-rc1+dev55 cFS-GroundSystem equuleus-rc1+dev14 **Includes:** *cFE* - nasa/cFE#2308 - nasa/cFE#2612 - nasa/cFE#2616 - nasa/cFE#2309 *osal* - nasa/osal#1486 *PSP* - nasa/PSP#441 *cFS-GroundSystem* - nasa/cFS-GroundSystem#233 - nasa/cFS-GroundSystem#235 - nasa/cFS-GroundSystem#236 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Tvisha Andharia <[email protected]> Co-authored by: Chris Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Addresses a mis-match with the parameter name in the CFE_PSP_MemSet handler and stub.
Testing performed
Built cFS with change, including coverage test that uncovered this issue.
Expected behavior changes
System(s) tested on
Oracle Linux 8
Contributor Info - All information REQUIRED for consideration of pull request
[email protected]