Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #32, Remove unnecessary parentheses around return values. #33

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Fix #32, Remove unnecessary parentheses around return values. #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fsw/src/md_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ int32 MD_AppInit(void)

} /* end if */

return (Status);
return Status;

} /* End of MD_AppInit */

Expand Down Expand Up @@ -328,7 +328,7 @@ int32 MD_InitSoftwareBusServices(void)

} /* end if */

return (Status);
return Status;

} /* End of MD_InitSoftwareBusServices */

Expand Down
6 changes: 3 additions & 3 deletions fsw/src/md_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ bool MD_Verify32Aligned(cpuaddr Address, uint32 Size)
IsAligned = true;
}

return (IsAligned);
return IsAligned;
}

/******************************************************************************/
Expand All @@ -182,7 +182,7 @@ bool MD_Verify16Aligned(cpuaddr Address, uint32 Size)
IsAligned = true;
}

return (IsAligned);
return IsAligned;
}

/******************************************************************************/
Expand Down Expand Up @@ -222,7 +222,7 @@ bool MD_ResolveSymAddr(MD_SymAddr_t *SymAddr, cpuaddr *ResolvedAddr)
else
Valid = false;
}
return (Valid);
return Valid;
}

/************************/
Expand Down
20 changes: 10 additions & 10 deletions unit-test/utilities/md_test_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,39 +100,39 @@ void MD_Test_TearDown(void)
int32 CFE_PSP_MemWrite8(cpuaddr MemoryAddress, uint8 ByteValue)
{
if (!MemoryAddress)
return (-1);
return -1;
else
return (CFE_PSP_SUCCESS);
return CFE_PSP_SUCCESS;
}

int32 CFE_PSP_MemRead16(cpuaddr MemoryAddress, uint16 *uint16Value)
{
if (!MemoryAddress)
return (-1);
return -1;
else
return (CFE_PSP_SUCCESS);
return CFE_PSP_SUCCESS;
}

int32 CFE_PSP_MemWrite16(cpuaddr MemoryAddress, uint16 uint16Value)
{
if (!MemoryAddress)
return (-1);
return -1;
else
return (CFE_PSP_SUCCESS);
return CFE_PSP_SUCCESS;
}

int32 CFE_PSP_MemRead32(cpuaddr MemoryAddress, uint32 *uint32Value)
{
if (!MemoryAddress)
return (-1);
return -1;
else
return (CFE_PSP_SUCCESS);
return CFE_PSP_SUCCESS;
}

int32 CFE_PSP_MemWrite32(cpuaddr MemoryAddress, uint32 uint32Value)
{
if (!MemoryAddress)
return (-1);
return -1;
else
return (CFE_PSP_SUCCESS);
return CFE_PSP_SUCCESS;
}