Fix #106, Simplify loop in LC_SampleAPReq by removing continue
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-106-remove-unnecessary-continue-from-LC_SampleAPReq
branch
from
b9e0762 to
b8b3a46
Compare
dzbaker
approved these changes
Nov 27, 2024
thnkslprpt
force-pushed
the
fix-106-remove-unnecessary-continue-from-LC_SampleAPReq
branch
from
b8b3a46 to
5f911a6
Compare
thnkslprpt
deleted the
fix-106-remove-unnecessary-continue-from-LC_SampleAPReq
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
LC_SampleAPReq#106LC_SampleAPReq: by checkingCountdownToStale > 0instead of== 0, there is no need for thecontinue.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Effectively no change.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt