Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apps should use CFE_MSG_PTR macro instead of cast or local unwrapping #9

Closed
skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #76
Closed

Apps should use CFE_MSG_PTR macro instead of cast or local unwrapping #9

skliper opened this issue Apr 22, 2022 · 0 comments · Fixed by #76
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

Apps typically cast to a CFE_MSG_Message_t or use *.Msg. Better to use abstracted CFE_MSG_PTR. NOTE - Not backwards compatible with Caelum so recommend not addressing in Draco.

Imported from GSFCCFS-1900
jphickey added a commit to jphickey/HS that referenced this issue Feb 23, 2023
@jphickey
WIP on nasa#9
de9531b
jphickey added a commit to jphickey/HS that referenced this issue Feb 23, 2023
@jphickey
Fix nasa#9, use CFE_MSG_PTR macro
237734c 
This also updates all data structures and function names to use the
proper naming conventions - that is:

 - Structure for each command that matches command name
 - Consistent application of CamelCase and command code name (_CC)

This also fixes a few other unsafe/improper casts regarding message
buffers.
@jphickey jphickey mentioned this issue Feb 23, 2023
Merged
2 tasks
jphickey added a commit to jphickey/HS that referenced this issue Feb 23, 2023
@jphickey
Fix nasa#9, update to fix documentation workflow issue
e3aee45 
This also fixes additional naming convention issues with the CC macros
where some underscores (word separator) were missing.
jphickey added a commit to jphickey/HS that referenced this issue Feb 23, 2023
@jphickey
Fix nasa#9, update to fix documentation workflow issue
2c84341 
This also fixes additional naming convention issues with the CC macros
where some underscores (word separator) were missing.
jphickey added a commit to jphickey/HS that referenced this issue Feb 23, 2023
@jphickey
Fix nasa#9, update to fix documentation workflow issue
fc92438 
This also fixes additional naming convention issues with the CC macros
where some underscores (word separator) were missing.
dzbaker added a commit that referenced this issue Feb 23, 2023
@dzbaker
Merge pull request #76 from jphickey/fix-9-cfe-msg-ptr
76915e9 
Fix #9, use CFE_MSG_PTR macro
@chillfig chillfig added this to the Equuleus milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #9, use CFE_MSG_PTR macro jphickey/HS
2 participants
@skliper @chillfig