Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #22, Resolve strict cppcheck warnings #23

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix #22, Resolve strict cppcheck warnings #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fsw/src/fm_cmd_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ bool FM_VerifyFileExists(char *Filename, uint32 BufferSize, uint32 EventID, cons
*
* \par Assumptions, External Events, and Notes:
*
* \param [in] Name Pointer to buffer containing name
* \param [in] Filename Pointer to buffer containing name
* \param [in] BufferSize Size of name character buffer
* \param [in] EventID Error event ID (command specific)
* \param [in] CmdText Error event text (command specific)
Expand All @@ -211,7 +211,7 @@ bool FM_VerifyFileExists(char *Filename, uint32 BufferSize, uint32 EventID, cons
*
* \sa #FM_GetFilenameState
*/
bool FM_VerifyFileNoExist(char *Name, uint32 BufferSize, uint32 EventID, const char *CmdText);
bool FM_VerifyFileNoExist(char *Filename, uint32 BufferSize, uint32 EventID, const char *CmdText);

/**
* \brief Verify File Is Not Open Function
Expand All @@ -222,7 +222,7 @@ bool FM_VerifyFileNoExist(char *Name, uint32 BufferSize, uint32 EventID, const c
*
* \par Assumptions, External Events, and Notes:
*
* \param [in] Name Pointer to buffer containing name
* \param [in] Filename Pointer to buffer containing name
* \param [in] BufferSize Size of name character buffer
* \param [in] EventID Error event ID (command specific)
* \param [in] CmdText Error event text (command specific)
Expand All @@ -233,7 +233,7 @@ bool FM_VerifyFileNoExist(char *Name, uint32 BufferSize, uint32 EventID, const c
*
* \sa #FM_GetFilenameState
*/
bool FM_VerifyFileNotOpen(char *Name, uint32 BufferSize, uint32 EventID, const char *CmdText);
bool FM_VerifyFileNotOpen(char *Filename, uint32 BufferSize, uint32 EventID, const char *CmdText);

/**
* \brief Verify Directory Exists Function
Expand Down
4 changes: 2 additions & 2 deletions fsw/src/fm_tbl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

int32 FM_TableInit(void)
{
int32 Status = CFE_SUCCESS;
int32 Status;

/* Initialize file system free space table pointer */
FM_GlobalData.FreeSpaceTablePtr = (FM_FreeSpaceTable_t *)NULL;
Expand Down Expand Up @@ -188,7 +188,7 @@ int32 FM_ValidateTable(FM_FreeSpaceTable_t *TablePtr)

void FM_AcquireTablePointers(void)
{
int32 Status = CFE_TBL_ERR_NEVER_LOADED;
int32 Status;

/* Allow cFE an opportunity to make table updates */
CFE_TBL_Manage(FM_GlobalData.FreeSpaceTableHandle);
Expand Down
4 changes: 2 additions & 2 deletions fsw/src/fm_tbl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ int32 FM_TableInit(void);
*
* \par Assumptions, External Events, and Notes:
*
* \param [in] TableData - Pointer to table data for verification.
* \param [in] TablePtr - Pointer to table data for verification.
*
* \return Validation status
* \retval #CFE_SUCCESS \copydoc CFE_SUCCESS
* \retval #FM_TABLE_VALIDATION_ERR \copybrief FM_TABLE_VALIDATION_ERR
*
* \sa /FM_AppInit
*/
int32 FM_ValidateTable(FM_FreeSpaceTable_t *TableData);
int32 FM_ValidateTable(FM_FreeSpaceTable_t *TablePtr);

/**
* \brief Acquire Table Data Pointer Function
Expand Down