Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #53, Remove unnecessary parentheses around return values. #54

Merged
merged 1 commit into from
Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fsw/src/ds_app.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ int32 DS_AppInitialize(void)
DS_MINOR_VERSION, DS_REVISION, DS_MISSION_REV, (void *)&DS_AppData);
}

return (Result);
return Result;

} /* End of DS_AppInitialize() */

Expand Down
2 changes: 1 addition & 1 deletion fsw/src/ds_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ bool DS_IsPacketFiltered(CFE_MSG_Message_t *MessagePtr, uint16 FilterType, uint1
}
}

return (PacketIsFiltered);
return PacketIsFiltered;

} /* End of DS_IsPacketFiltered() */

Expand Down
32 changes: 16 additions & 16 deletions fsw/src/ds_table.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ int32 DS_TableInit(void)
DS_TableManageFilter();
}

return (Result1);
return Result1;

} /* End of DS_TableInit() */

Expand Down Expand Up @@ -438,7 +438,7 @@ int32 DS_TableVerifyDestFile(const void *TableData)
"Destination file table verify results: desc text = %s, good entries = %d, bad = %d, unused = %d",
DescResult, (int)CountGood, (int)CountBad, (int)CountUnused);

return (Result);
return Result;

} /* End of DS_TableVerifyDestFile() */

Expand Down Expand Up @@ -509,7 +509,7 @@ bool DS_TableVerifyDestFileEntry(DS_DestFileEntry_t *DestFileEntry, uint8 TableI
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifyDestFileEntry() */

Expand Down Expand Up @@ -563,7 +563,7 @@ int32 DS_TableVerifyFilter(const void *TableData)
"Filter table verify results: desc text = %s, good entries = %d, bad = %d, unused = %d",
DescResult, (int)CountGood, (int)CountBad, (int)CountUnused);

return (Result);
return Result;

} /* End of DS_TableVerifyFilter() */

Expand Down Expand Up @@ -641,7 +641,7 @@ bool DS_TableVerifyFilterEntry(DS_PacketEntry_t *PacketEntry, int32 TableIndex,
}
}

return (Result);
return Result;

} /* End of DS_TableVerifyFilterEntry() */

Expand All @@ -666,7 +666,7 @@ bool DS_TableEntryUnused(const void *TableEntry, int32 BufferSize)
}
}

return (Result);
return Result;

} /* End of DS_TableEntryUnused() */

Expand All @@ -685,7 +685,7 @@ bool DS_TableVerifyFileIndex(uint16 FileTableIndex)
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifyFileIndex() */

Expand Down Expand Up @@ -720,7 +720,7 @@ bool DS_TableVerifyParms(uint16 Algorithm_N, uint16 Algorithm_X, uint16 Algorith
}
}

return (Result);
return Result;

} /* End of DS_TableVerifyParms() */

Expand All @@ -739,7 +739,7 @@ bool DS_TableVerifyType(uint16 TimeVsCount)
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifyType() */

Expand All @@ -758,7 +758,7 @@ bool DS_TableVerifyState(uint16 EnableState)
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifyState() */

Expand All @@ -777,7 +777,7 @@ bool DS_TableVerifySize(uint32 MaxFileSize)
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifySize() */

Expand All @@ -796,7 +796,7 @@ bool DS_TableVerifyAge(uint32 MaxFileAge)
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifyAge() */

Expand All @@ -815,7 +815,7 @@ bool DS_TableVerifyCount(uint32 SequenceCount)
Result = false;
}

return (Result);
return Result;

} /* End of DS_TableVerifyCount() */

Expand Down Expand Up @@ -957,7 +957,7 @@ int32 DS_TableCreateCDS(void)
Result = CFE_SUCCESS;
}

return (Result);
return Result;

} /* End of DS_TableCreateCDS() */

Expand Down Expand Up @@ -1123,7 +1123,7 @@ int32 DS_TableAddMsgID(CFE_SB_MsgId_t MessageID, int32 FilterIndex)
LinkList->Next = NewLink;
}

return (HashIndex);
return HashIndex;

} /* End of DS_TableAddMsgID() */

Expand Down Expand Up @@ -1167,7 +1167,7 @@ int32 DS_TableFindMsgID(CFE_SB_MsgId_t MessageID)
HashLink = HashLink->Next;
}

return (FilterTableIndex);
return FilterTableIndex;

} /* End of DS_TableFindMsgID() */

Expand Down