Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .github/workflows/unit-test-coverage.yml with no max missed lines or branches #35

Closed
3 tasks done
chillfig opened this issue Jul 6, 2022 · 0 comments · Fixed by #36
Closed
3 tasks done
Assignees
Milestone

Comments

@chillfig
Copy link
Contributor

chillfig commented Jul 6, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Max-missed-branches and max-missed-lines should be removed to indicate 100% unit test coverage.

max-missed-branches: 11
max-missed-lines: 5

Describe the solution you'd like
Remove the max-missed-branches and max-missed-lines from .github/workflows/unit-test-coverage.yml after #34 and #32 are merged and closed.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Justin Figueroa, ASRC Federal

@chillfig chillfig self-assigned this Jul 6, 2022
@skliper skliper added this to the Draco milestone Jul 6, 2022
chillfig added a commit to chillfig/DS that referenced this issue Jul 12, 2022
dzbaker added a commit that referenced this issue Jul 20, 2022
Fix #35, Removes max missed branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants