Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #382, Align CF Command Counter implementation to cFS standard #383

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes CF command counters format inconsistent with cFS #382
    • Command counters renamed
      • cmd renamed to CommandCounter
      • err renamed to CommandErrorCounter
    • Command counters changed from size 16 to size 8, and moved out of their own struct into the HK packet directly (this is how all other cFS components/apps implemented the counters)
    • hk renamed to HkPacket (most cFS components/apps use this common name for the housekeeping packet)

Note: if the CamelCase is an issue, can still implement these changes as snake_case, although I guess now is as good a time as any to start converting CF variables to CamelCase. If so I can open a new issue to flag that all variables should be changed over - all at once (if someone wants to implement that) or gradually as changes are made.
CF is the only cFS app/component to use snake_case for naming variables.

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit Tests etc.).

Expected behavior changes
Command/CommandError counters now held directly in the HK packet, instead of through an additional struct member.

This PR improves consistency across cFS, and makes future maintenance easier as variables are named and located as expected.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker requested a review from havencarlson May 4, 2023 18:37
@thnkslprpt thnkslprpt force-pushed the fix-382-align-cf-command-counter-implementation-with-cfs branch from dcd15dd to 48c5322 Compare May 5, 2023 02:47
@dzbaker dzbaker merged commit 4e97d3b into nasa:main May 18, 2023
@thnkslprpt thnkslprpt deleted the fix-382-align-cf-command-counter-implementation-with-cfs branch May 18, 2023 21:19
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
@dzbaker dzbaker mentioned this pull request Jul 11, 2023
2 tasks
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
@dzbaker dzbaker mentioned this pull request Jul 11, 2023
2 tasks
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
This reverts commit 4e97d3b, reversing
changes made to 913b5fc.
dzbaker added a commit that referenced this pull request Jul 11, 2023
dzbaker added a commit to dzbaker/CF that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CF command counters format inconsistent with cFS
4 participants