Fix #216, #227 - Adds strict cppcheck and fixes remaining warnings (replace codec macros) #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
Build/run unit tests, also manually ran strict cppcheck on fsw/
Expected behavior changes
None except now enforcing strict cppcheck in CI
System(s) tested on
Additional context
Workflow will fail until #226 is merged since one of the warnings were fixed there.
Also will fail until nasa/cFS#454 is merged based on the directory fix
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC