You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the CF README.md file to see if the feature is in the major future work.
I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe. ALL_CHANNELS, ALL_POLLDIRS, COMPOUND_KEY used in command processing shouldn't be defined in a *.c where it's inaccessible and somewhat hidden. The names aren't great either, better to prefix w/ app.
skliper
changed the title
Local #defines in cf_cmd.c but used as special values in command processing (w/ repeat dfn in tests)
Local #defines in cf_cmd.c used as special values in command processing (w/ repeat dfn in tests)
Jun 16, 2022
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
ALL_CHANNELS
,ALL_POLLDIRS
,COMPOUND_KEY
used in command processing shouldn't be defined in a *.c where it's inaccessible and somewhat hidden. The names aren't great either, better to prefix w/ app.CF/fsw/src/cf_cmd.c
Lines 41 to 43 in 593d61a
Describe the solution you'd like
Move into cfe_msg.h and rename as
CF_ALL_CHANNELS
and similar, which would allow removal from cf_test_utils.h:CF/unit-test/utilities/cf_test_utils.h
Line 53 in 593d61a
Describe alternatives you've considered
None
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: