Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of goto, coding standard violation #225

Closed
3 tasks done
skliper opened this issue Apr 8, 2022 · 3 comments · Fixed by #269
Closed
3 tasks done

Replace use of goto, coding standard violation #225

skliper opened this issue Apr 8, 2022 · 3 comments · Fixed by #269
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Apr 8, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
goto violates power of ten and JPL coding standards, typically avoided in cFS code.

Describe the solution you'd like
Refactor

Describe alternatives you've considered
None

Additional context
Static analysis warning that showed up in #218 but wasn't resolved as part of that issue fix

Requester Info
Jacob Hageman - NASA/GSFC

@astrogeco
Copy link
Contributor

@skliper how do you feel about adding this to Draco?

@skliper
Copy link
Contributor Author

skliper commented Jun 21, 2022

@astrogeco It's non-trivial, but if we've got the resources it needs to get done.

@havencarlson havencarlson self-assigned this Jun 22, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 22, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 22, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 22, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 22, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 22, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 24, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 24, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jun 24, 2022
@skliper skliper added this to the Draco milestone Jul 13, 2022
@skliper
Copy link
Contributor Author

skliper commented Jul 13, 2022

Adding to Draco for tracking as @havencarlson has it close to resolved and good to close this violation if there's time this round. Can always reassess if we run out of time.

havencarlson added a commit to havencarlson/CF that referenced this issue Jul 14, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 14, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 14, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 14, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 20, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 20, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 20, 2022
havencarlson added a commit to havencarlson/CF that referenced this issue Jul 20, 2022
dzbaker added a commit that referenced this issue Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants