Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CF source code needs format/whitespace scrub #15

Closed
jphickey opened this issue Nov 19, 2021 · 0 comments · Fixed by #16
Closed

CF source code needs format/whitespace scrub #15

jphickey opened this issue Nov 19, 2021 · 0 comments · Fixed by #16
Assignees
@jphickey
Labels
draco-rc1
Milestone
Draco

Comments

@jphickey
Copy link
Contributor

In the CF-3.0.0 release candidate, the source code files have many formatting discrepancies from the CFE/CFS recommendations.

Before continuing development with other fixes, the source should be sent through the "clang-format" tool using the same rules as used for the CFE framework. This will establish a baseline for fixing other issues reported by CF users thus far.

Since this is likely to affect many lines, it must be done as an isolated commit, before any other code changes are done, as it will not be easy to merge/rebase with this type of change.
@jphickey jphickey self-assigned this Nov 19, 2021
jphickey added a commit that referenced this issue Nov 19, 2021
@jphickey
Fix #15, initial pass through format tool
1f10a85 
This scrubs the whitespace on all .c/.h header files to match
the formatting used by the CFE framework.  This affects many
lines, but only changes whitespace.

NOTE: this commit is strictly limited to whitespace fixes.  It
does not change the fundamental source code at all.
@jphickey jphickey mentioned this issue Nov 19, 2021
Merged
@jphickey jphickey linked a pull request Nov 19, 2021 that will close this issue
Fix #15, initial pass through the format tool used by CFE framework #16
Merged
astrogeco added a commit that referenced this issue Nov 29, 2021
@astrogeco
Merge pull request #16 from nasa/fix-15-initial-format-scrub
7b99b91 
Fix #15, initial pass through the format tool used by CFE framework
@skliper skliper added this to the Draco milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
draco-rc1
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #15, initial pass through the format tool used by CFE framework nasa/CF
2 participants
@jphickey @skliper