Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command valid and rejected counters do not increment correctly #125

Closed
semaldona opened this issue Dec 13, 2021 · 0 comments · Fixed by #167
Closed

Command valid and rejected counters do not increment correctly #125

semaldona opened this issue Dec 13, 2021 · 0 comments · Fixed by #167
Assignees
@jphickey
Labels
bug draco-rc1
Milestone
Draco

Comments

@semaldona
Copy link

For certain invalid commands CF will increment the valid counter. For certain valid commands CF will increment the invalid counter. The CF_TsnChanAction function does not appear to correctly interpret the return status from certain sub-functions that return the count of matched transactions. It assumes a non-zero return value is failure, but actually it is the count of transaction matches.

This can be seen with the following command opcodes: ABANDON, CANCEL, SUSPEND, RESUME
@jphickey jphickey self-assigned this Jan 12, 2022
@jphickey jphickey added the bug label Jan 12, 2022
jphickey added a commit to jphickey/CF that referenced this issue Jan 12, 2022
@jphickey
Fix nasa#125, correct accept/reject counter increments
dab6f02 
For commands that rely on CF_TsnChanAction(), this is documented as
returning a count of the number of transactions affected.  Therefore,
a return value >0 means that the operation was successful (or at least
it matched something), and a return value <=0 means failure.

- Fixes a case where the function did not adhere to its documented return
- Fixes passing the result to CF_CmdCond() which needs a translation.
@jphickey jphickey mentioned this issue Jan 12, 2022
Merged
astrogeco added a commit that referenced this issue Jan 18, 2022
@astrogeco
Merge pull request #167 from jphickey/fix-125-cmd-counts
1d9719b 
Fix #125, correct accept/reject counter increments
@skliper skliper added this to the Draco milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug draco-rc1
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #125, correct accept/reject counter increments jphickey/CF
3 participants
@jphickey @semaldona @skliper