Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sourcemaps for legible stack traces in lambdas #2770

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Dec 9, 2024

Fixes #2769.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 6.11%. Comparing base (7312c55) to head (2c97c7f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
app/email-incoming/circulars/index.ts 0.00% 1 Missing ⚠️
app/email-incoming/support/index.ts 0.00% 1 Missing ⚠️
app/scheduled/ads/index.ts 0.00% 1 Missing ⚠️
app/scheduled/circulars/index.ts 0.00% 1 Missing ⚠️
app/table-streams/circulars/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2770   +/-   ##
=====================================
  Coverage   6.10%   6.11%           
=====================================
  Files        168     168           
  Lines       4258    4270   +12     
  Branches     468     468           
=====================================
+ Hits         260     261    +1     
- Misses      3996    4007   +11     
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger marked this pull request as draft December 9, 2024 19:02
@lpsinger lpsinger marked this pull request as ready for review December 10, 2024 02:27
@lpsinger lpsinger requested review from Courey and dakota002 December 10, 2024 02:27
@dakota002 dakota002 merged commit edd94cf into nasa-gcn:main Dec 10, 2024
12 checks passed
@lpsinger lpsinger deleted the sourcemaps branch December 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure source maps for legible stack traces in Lambda logs
2 participants