Do not require Healpy on Windows #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Healpy does not have builds for windows; see healpy/healpy#25. `npm run dev` will now work again on Windows, although the ACROSS API endpoints will bne nonfunctional on Windows. Addresses nasa-gcn#2038.
lpsinger
force-pushed
the
no-healpy-on-windows
branch
from
cc8709c to
f6bcd3f
Compare
jak574
approved these changes
Mar 12, 2024
|
@dakota002, would you please test if this fixes local sandbox development on your laptop? |
dakota002
approved these changes
Mar 12, 2024
|
Testing now |
|
Looks good, runs without issue on my Windows laptop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Healpy does not have builds for windows; see
healpy/healpy#25.
npm run devwill now work again on Windows, although the ACROSS API endpoints will bne nonfunctional on Windows.Addresses #2038.