docs: add narwhals-gif to README.md #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
love this, we're lucky to have you! 😍 really minor, but it looks like the order now goes: pandas, rapids, polars, pandas. So, watching it in a loop results in pandas being visited twice in a row? |
|
weird but indeed, let me fix that then, I'm afraid I'll have to do again a separate PR , I hope you don't mind |
MarcoGorelli
approved these changes
Aug 22, 2024
|
yeah let's go |
MarcoGorelli
changed the title
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for making it a separate PR but I didn't know how to turn the gif into github-asset other than just droping it in the README.md (and didn't want to experiment with branches on github)
Does this looks now more clear and comprehensible?
Do you like the white background? I feel like it looks better in the README.md but if anybody what's back the cotton-candy-theme let me know.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.