feat: add is_in to DaskExpr and mark is_duplicated and is_unique as not implemented
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_unique not implemented precommit
FBruzzesi
reviewed
Aug 16, 2024
| raise NotImplementedError(msg) | ||
|
|
||
| def is_unique(self: Self) -> Self: | ||
| msg = "`Expr.is_duplicated` is not support since Dask currently has no native duplicated check" |
There was a problem hiding this comment.
I am late but
- msg = "`Expr.is_duplicated` is not support since Dask currently has no native duplicated check"
+ msg = "`Expr.is_unique` is not support since Dask currently has no native duplicated check" There was a problem hiding this comment.
aah crap, thanks - fancy bundling this in with another one?
There was a problem hiding this comment.
Doh! Sorry both 🤦♂️
There was a problem hiding this comment.
No worries! I tend to say that until a release we are fine to mess up a bit 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Main implementation here is
is_inwhich is fairly simple (I've just used Dask's ownisismethod, and then removed thexfailfrom the Dask pytest).I've also marked in
is_duplicatedandis_uniqueas not implemented. I think this is the right call because Dask doesn't have any internalduplicatedcheck (at least yet! Looks like it could be on the cards soon-ish)Here's the Github issues/PRs relating to Dask duplication checks:
drop_duplicatesdask/dask#10542