feat: implement LazyFrame.head for Dask (plus: run tpc-h q2 query with Dask present) #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
more-dask-tpch
branch
from
60465ed to
d899836
Compare
MarcoGorelli
changed the title
FBruzzesi
reviewed
Aug 10, 2024
.github/workflows/extremes.yml
Outdated
| python-version: ${{ matrix.python-version }} | ||
| - name: Install uv (Unix) | ||
| run: curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| - name: install-minimu-versions |
There was a problem hiding this comment.
Tiny typo
Suggested change
| - name: install-minimu-versions | |
| - name: install-minimum-versions |
narwhals/_dask/dataframe.py
Outdated
| @@ -136,6 +140,11 @@ def with_row_index(self: Self, name: str) -> Self: | |||
| def rename(self: Self, mapping: dict[str, str]) -> Self: | |||
| return self._from_native_dataframe(self._native_dataframe.rename(columns=mapping)) | |||
|
|
|||
| def head(self: Self, n: int) -> Self: | |||
| return self._from_native_dataframe( | |||
| self._native_dataframe.head(n=n, compute=False) | |||
There was a problem hiding this comment.
Should we also pass npartititions=-1 to parse all partitions if needed? I am not sure how this works: docs
There was a problem hiding this comment.
good points, thanks
10 tasks
|
thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added
headto make sure this notebook could rundrive-by:
ibis-frameworkinstall from other notebooks (as we'll no longer benchmark running pandas/dask via ibis anyway)What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.