Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dask expr __invert__, is_null, n_unique methods #763

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Convers a few methods and refactor is_null test

@github-actions github-actions bot added the enhancement New feature or request label Aug 9, 2024
data_na = {"a": [None, 3, 2], "z": [7.0, None, None]}
expected = {"a": [True, False, False], "z": [True, False, False]}
df = nw.from_native(constructor(data_na))
result = df.select(nw.col("a").is_null(), ~nw.col("z").is_null())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, this is the only place in which we also test __invert__, that's why the implementation ended up in the same pr

@MarcoGorelli
Copy link
Member

thanks! could you resolve the conflict please?

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli merged commit 2395e08 into main Aug 9, 2024
23 checks passed
@FBruzzesi FBruzzesi deleted the feat/dask-expr-is_null branch August 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants