feat: add NotImplementedError error for index changing methods Dask #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
reviewed
Aug 8, 2024
narwhals/_dask/expr.py
Outdated
| @@ -445,6 +450,16 @@ def clip( | |||
| returns_scalar=False, | |||
| ) | |||
|
|
|||
| def head(self) -> NoReturn: | |||
| # We can't (yet?) allow methods which modify the index | |||
| msg = "`Expr.head` is not supported for the Dask backend. Please use `LazyFrame.head` instead." | |||
There was a problem hiding this comment.
Quick heads up: sadly DaskLazyframe also doesn't implement head (nor tail) 🥲
There was a problem hiding this comment.
🫠 Where can I check that? I only found Dask API reference for Arrays and DataFrames
There was a problem hiding this comment.
LazyFrame will point to DaskLazyFrame for the dask backend, and the message is suggesting to use such method, so I guess you can check if present in narwhals/_dask/dataframe.py?
MarcoGorelli
approved these changes
Aug 8, 2024
mistShard
pushed a commit
to mistShard/narwhals
that referenced
this pull request
Aug 8, 2024
…arwhals-dev#744) * add notImplemented error for index changing methods Dask * add NotImplementedError to index changing methods Dask * add NotImplementedError in Dask drop_null/count * Update expr.py --------- Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
If this looks good I'll also add
NotImplementedErrorto the following methods and this PRExpr.sortExpr.headExpr.tail