Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Expr.abs to Dask #728

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Conversation

mistShard
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

I used abs_test.py to test the code. I'm not sure if the test is configured to test the method.

@github-actions github-actions bot added the enhancement New feature or request label Aug 6, 2024
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR πŸš€

You just needs to remove the dask xfail in the dedicate abs test

@mistShard
Copy link
Contributor Author

Thanks for the PR πŸš€

You just needs to remove the dask xfail in the dedicate abs test

done

@FBruzzesi
Copy link
Member

Thanks for the PR πŸš€
You just needs to remove the dask xfail in the dedicate abs test

done

there is an additional test that passes but marked as fail πŸ™ƒ

@mistShard
Copy link
Contributor Author

Thanks for the PR πŸš€
You just needs to remove the dask xfail in the dedicate abs test

done

there is an additional test that passes but marked as fail πŸ™ƒ

Please, which test is that. I have looked around and I still cannot find it. I have run abs_test.py multiple times and do not get an xfail or any other kind of failure. I did add return_scalar to _from_call.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mistShard , and @FBruzzesi for reviewing

@MarcoGorelli MarcoGorelli merged commit 5c9c54c into narwhals-dev:main Aug 8, 2024
20 checks passed
@condekind condekind mentioned this pull request Aug 8, 2024
10 tasks
mistShard added a commit to mistShard/narwhals that referenced this pull request Aug 8, 2024
* Removed check-backend script

* Added  expr.abs

* Removed xfail from abs.py

* Added 'return_scalar' and made tests pass without xfail'

---------

Co-authored-by: benjinwangele <gbnwangele@gmail>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants