-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Expr.abs
to Dask
#728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR π
You just needs to remove the dask xfail in the dedicate abs
test
done |
there is an additional test that passes but marked as fail π |
Please, which test is that. I have looked around and I still cannot find it. I have run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mistShard , and @FBruzzesi for reviewing
* Removed check-backend script * Added expr.abs * Removed xfail from abs.py * Added 'return_scalar' and made tests pass without xfail' --------- Co-authored-by: benjinwangele <gbnwangele@gmail>
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
I used
abs_test.py
to test the code. I'm not sure if the test is configured to test the method.