docs: Fix how-it-works, add favicon+logo #710
Conversation
github-actions
bot
added
the
documentation
apple-touch-icon.png
Outdated
There was a problem hiding this comment.
I don't have a mac to try this, but that's new to me. I can't find it in any mkdocs-material docs either 😕
There was a problem hiding this comment.
When I was building the docs locally, there was a 404 response when the favicon was supposed to be loaded. (I have a mac):
WARNING - [13:54:22] "GET /apple-touch-icon-precomposed.png HTTP/1.1" code 404
WARNING - [13:54:22] "GET /apple-touch-icon.png HTTP/1.1" code 404
So I saw this.. And now it works:
But it's true that it looks weird to have that copy of the .png file there. I don't know if it will work on GitHubPages. I can remove it if you think I should.
There was a problem hiding this comment.
If possible I would give it a try without it. I never had to have a duplicate when deploying to github pages
There was a problem hiding this comment.
Removed.
I never had to have a duplicate when deploying to github pages
The issue happens with a mac and safari. At least for me. Maybe my mac is broken. 🤔
There was a problem hiding this comment.
Just noticed the docs are live, how does it look from safari?
There was a problem hiding this comment.
Hi @FBruzzesi, the favicon is not found.
|
I forgot: I can change the favicon & icon. I didn't use Magdalena's logos on discord because I wasn't sure that people agreed on one. Or I can remove them all together. |
* Fix how-it-works, add favicon+logo * icon for macs * removed extra .png file
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
markdown-execsettings were added (I think).apple-touch-icon.pngfor macs to find it.