-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Expr.round
to Dask
#709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Tests are passing but marked as xfail!
After fixing that we can merge! ππΌ
yup, @mistShard could you try removing the xfails from the round test for dask? |
could you try removing the xfails from the round test for dask? |
@MarcoGorelli I have done that and the tests do not run. I instead get this error:
Do I need to update pytest? |
other tests also show the same error |
You need to update your environment, run pip install -U -r requirements-dev.txt |
bit of a dumb question here. As a rule, how do I know by myself that my environment needs to be updated? |
@MarcoGorelli tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good, thanks @mistShard !
* Completed round method * Made expr.round pass test --------- Co-authored-by: benjinwangele <gbnwangele@gmail>
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.