Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Expr.round to Dask #709

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

mistShard
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@github-actions github-actions bot added the enhancement New feature or request label Aug 2, 2024
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Tests are passing but marked as xfail!
After fixing that we can merge! πŸ™ŒπŸΌ

@MarcoGorelli
Copy link
Member

yup, @mistShard could you try removing the xfails from the round test for dask?

@MarcoGorelli
Copy link
Member

could you try removing the xfails from the round test for dask?

@mistShard
Copy link
Contributor Author

@MarcoGorelli I have done that and the tests do not run. I instead get this error:

INTERNALERROR>     self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")
INTERNALERROR>   File "C:\Users\hp\Documents\Work\OpenTeams\narwhals\.venv\Lib\site-packages\_pytest\config\__init__.py", line 1487, in _warn_or_fail_if_strict
INTERNALERROR>     self.issue_config_time_warning(PytestConfigWarning(message), stacklevel=3)
INTERNALERROR>   File "C:\Users\hp\Documents\Work\OpenTeams\narwhals\.venv\Lib\site-packages\_pytest\config\__init__.py", line 1539, in issue_config_time_warning
INTERNALERROR>     warnings.warn(warning, stacklevel=stacklevel)
INTERNALERROR> pytest.PytestConfigWarning: Unknown config option: env

========================================================== no tests ran in 0.19s 

Do I need to update pytest?

@mistShard
Copy link
Contributor Author

other tests also show the same error

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Aug 5, 2024

You need to update your environment, run

pip install -U -r requirements-dev.txt

@mistShard
Copy link
Contributor Author

bit of a dumb question here. As a rule, how do I know by myself that my environment needs to be updated?

@mistShard
Copy link
Contributor Author

@MarcoGorelli tests pass

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good, thanks @mistShard !

@MarcoGorelli MarcoGorelli merged commit 65e9e7c into narwhals-dev:main Aug 6, 2024
20 checks passed
aivanoved pushed a commit to aivanoved/narwhals that referenced this pull request Aug 6, 2024
* Completed round method

* Made expr.round pass test

---------

Co-authored-by: benjinwangele <gbnwangele@gmail>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants