Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Contributing guide correction #706

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

DeaMariaLeon
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

It was wrong to instruct that the title should start "with an uppercase letter". That's what I get for copy/pasting. πŸ˜…
Added TLDR while I'm at it.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 2, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DeaMariaLeon ! feel free to merge

@DeaMariaLeon DeaMariaLeon merged commit 48edb7f into narwhals-dev:main Aug 2, 2024
20 checks passed
montanarograziano pushed a commit to montanarograziano/narwhals that referenced this pull request Aug 2, 2024
aivanoved pushed a commit to aivanoved/narwhals that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants