Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark failing dask tests, add dask to constructor #697

Conversation

aidoskanapyanov
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@aidoskanapyanov
Copy link
Contributor Author

I didn't get how to fix this part yet
image

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, solid effort here! nice one!

let's gets this in before merge conflicts arise πŸ˜„

@MarcoGorelli MarcoGorelli merged commit 204f315 into narwhals-dev:main Aug 1, 2024
20 checks passed
montanarograziano pushed a commit to montanarograziano/narwhals that referenced this pull request Aug 2, 2024
aivanoved pushed a commit to aivanoved/narwhals that referenced this pull request Aug 6, 2024
@aidoskanapyanov aidoskanapyanov deleted the tests_add_dask_to_main_test_suit_mark_failing branch August 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants