Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dask any_horizontal and generalize all_horizontal #693

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
inteon Tim Ramlot
@github-actions github-actions bot added the enhancement New feature or request label Jul 31, 2024
Comment on lines -55 to +54
return reduce(lambda x, y: x & y, flatten(exprs)) # type: ignore[no-any-return] # pragma: no cover
return reduce(lambda x, y: x & y, parse_into_exprs(*exprs, namespace=self))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with flatten it would only work by passing nw.col (or an expression in general). With parsing we can use string directly. I added tests for that

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @FBruzzesi !

@MarcoGorelli MarcoGorelli merged commit 0e4b184 into main Aug 2, 2024
23 checks passed
montanarograziano pushed a commit to montanarograziano/narwhals that referenced this pull request Aug 2, 2024
aivanoved pushed a commit to aivanoved/narwhals that referenced this pull request Aug 6, 2024
@FBruzzesi FBruzzesi deleted the feat/dask-any-horizontal branch August 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants