Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fill_null to DaskExpr #685

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

lucianosrp
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

Maybe it's soon time to refactor dask_test.py ?

@github-actions github-actions bot added the enhancement New feature or request label Jul 30, 2024
@lucianosrp lucianosrp marked this pull request as ready for review July 30, 2024 16:17
@lucianosrp lucianosrp requested a review from MarcoGorelli July 30, 2024 16:17
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks @lucianosrp !

@MarcoGorelli MarcoGorelli merged commit 78c2165 into narwhals-dev:main Jul 30, 2024
20 checks passed
@lucianosrp lucianosrp deleted the feat/fill-nulls branch August 4, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants