Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dask expr dt.nanosecond implementation #678

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: dask expr dt.nanosecond implementation #678

merged 1 commit into from
Jul 30, 2024

Conversation

aidoskanapyanov
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@github-actions github-actions bot added the fix label Jul 30, 2024
MarcoGorelli
MarcoGorelli approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aidoskanapyanov !

@MarcoGorelli MarcoGorelli merged commit 9b1eecc into narwhals-dev:main Jul 30, 2024
20 checks passed
@aidoskanapyanov aidoskanapyanov deleted the fix_dask_expr_dt_nanosecond branch July 30, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aidoskanapyanov @MarcoGorelli